Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

DmytroAlipov
Copy link
Contributor

Description

This is a backport from the master branch.

Steps to Reproduce:

  • Login by the user with staff rights
  • During purchase click on the link "Click here to purchase multiple seats in this course"
  • Confirm and pay
  • Activate the course with one of the coupons sent to your email
  • Open /dashboard page
dashboard

The issue was that the date-time also included milliseconds, which is not acceptable for converting the date and time into the required format.

ValueError: time data '2033-06-25T11:40:12.267999Z' does not match format '%Y-%m-%dT%H:%M:%SZ'

@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 12, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-500-after-applying-coupon-palm branch from 996c67d to 6195d42 Compare July 13, 2023 10:30
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 14, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 18, 2023
@mphilbrick211 mphilbrick211 requested a review from a team July 19, 2023 17:22
@mphilbrick211
Copy link

Hi @colinbrash! Would you or another member of the @openedx/revenue-squad (purchase) be able to review and merge this for us? Thanks!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@pshiu pshiu merged commit 8a1cd63 into openedx-unsupported:open-release/palm.master Aug 7, 2023
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-500-after-applying-coupon-palm branch August 7, 2023 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants